Skip to content

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Aug 5, 2020

Changes

pytest has two mechanisms to select tests which are expressions passed to -k or marker expressions passed to -m. This PR implements the same behavior.

Additionally, the PR restructured some parts of pytask and hopefully makes circular imports less likely.

@tobiasraabe tobiasraabe added this to the v0.0.5 milestone Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #13 into main will decrease coverage by 5.48%.
The diff coverage is 89.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   89.11%   83.63%   -5.49%     
==========================================
  Files          36       37       +1     
  Lines        1782     1949     +167     
==========================================
+ Hits         1588     1630      +42     
- Misses        194      319     +125     
Flag Coverage Δ
#end_to_end ?
#integration ?
#unit 83.63% <89.67%> (+9.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_parametrize.py 39.13% <40.00%> (-56.22%) ⬇️
src/pytask/mark_/structures.py 90.10% <75.00%> (ø)
tests/test_mark.py 80.45% <78.43%> (-17.05%) ⬇️
src/pytask/mark_/__init__.py 80.95% <80.95%> (ø)
src/pytask/cli.py 94.64% <96.77%> (+5.75%) ⬆️
src/pytask/mark_/expression.py 98.34% <98.34%> (ø)
src/pytask/__init__.py 100.00% <100.00%> (ø)
src/pytask/collect.py 88.18% <100.00%> (-3.41%) ⬇️
src/pytask/config.py 91.93% <100.00%> (-8.07%) ⬇️
src/pytask/execute.py 87.61% <100.00%> (-8.85%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbcb55...4b1ab42. Read the comment docs.

@tobiasraabe tobiasraabe merged commit d7a03aa into main Aug 7, 2020
@tobiasraabe tobiasraabe deleted the expressions branch August 7, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant