Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ids of PythonNodes. #433

Merged
merged 8 commits into from Oct 2, 2023
Merged

Fix ids of PythonNodes. #433

merged 8 commits into from Oct 2, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 2, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a77963) 95.46% compared to head (0d9c80e) 95.48%.

❗ Current head 0d9c80e differs from pull request most recent head f6e1601. Consider uploading reports for the commit f6e1601 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   95.46%   95.48%   +0.01%     
==========================================
  Files          96       96              
  Lines        8497     8523      +26     
==========================================
+ Hits         8112     8138      +26     
  Misses        385      385              
Flag Coverage Δ
end_to_end 82.67% <78.72%> (-0.06%) ⬇️
integration 39.44% <14.89%> (-0.06%) ⬇️
unit 65.83% <65.95%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect.py 92.99% <100.00%> (+0.23%) ⬆️
src/_pytask/collect_command.py 89.84% <100.00%> (+0.58%) ⬆️
src/_pytask/collect_utils.py 95.95% <100.00%> (+0.04%) ⬆️
src/_pytask/models.py 100.00% <100.00%> (ø)
src/_pytask/report.py 100.00% <ø> (ø)
tests/test_collect_command.py 100.00% <100.00%> (ø)
tests/test_dag.py 98.14% <100.00%> (+0.16%) ⬆️
tests/test_collect.py 97.07% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 02bf5e4 into main Oct 2, 2023
15 checks passed
@tobiasraabe tobiasraabe deleted the little-fixes branch October 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant