Skip to content

Two fixes for the execution related to pytask-latex. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2020

Conversation

tobiasraabe
Copy link
Member

Changes

  • Errors during the execution will cause the exit code to be one.
  • When a task previously failed, it also was decorated with the skip_ancestor_failed decorator. It should only be applied to descendants.

@tobiasraabe tobiasraabe added this to the v0.0.3 milestone Jul 19, 2020
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #7 into main will increase coverage by 0.11%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   93.99%   94.10%   +0.11%     
==========================================
  Files          31       31              
  Lines        1382     1391       +9     
==========================================
+ Hits         1299     1309      +10     
+ Misses         83       82       -1     
Flag Coverage Δ
#end_to_end 82.24% <83.33%> (+0.26%) ⬆️
#integration 50.53% <44.44%> (-0.04%) ⬇️
#unit 78.86% <72.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytask/main.py 92.20% <66.66%> (+1.54%) ⬆️
src/pytask/dag.py 100.00% <100.00%> (ø)
src/pytask/exceptions.py 100.00% <100.00%> (ø)
src/pytask/execute.py 96.46% <100.00%> (+0.09%) ⬆️
src/pytask/parametrize.py 100.00% <100.00%> (ø)
src/pytask/skipping.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1abd63...1dd1ec2. Read the comment docs.

@tobiasraabe tobiasraabe changed the title Fixes related to pytask-latex. Two fixes for the execution related to pytask-latex. Jul 19, 2020
@tobiasraabe tobiasraabe merged commit 950ae9b into main Jul 19, 2020
@tobiasraabe tobiasraabe deleted the fix-skipping branch July 19, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant