Skip to content

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Apr 11, 2021

Changes

  • An error is raised on Windows if the casing is wrong.
  • No errors on case-insensitive macOS sinceI found no way and tested some approaches. Contributions welcome.
  • On case-sensitive systems a hint is shown when nodes cannot be found.

@tobiasraabe tobiasraabe added this to the v0.0.15 milestone Apr 11, 2021
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #81 (258c488) into main (b6ae5f3) will decrease coverage by 0.29%.
The diff coverage is 73.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   90.36%   90.06%   -0.30%     
==========================================
  Files          58       58              
  Lines        4793     4863      +70     
==========================================
+ Hits         4331     4380      +49     
- Misses        462      483      +21     
Flag Coverage Δ
end_to_end 76.70% <58.75%> (-0.33%) ⬇️
integration 41.76% <51.25%> (+0.12%) ⬆️
unit 67.57% <71.25%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/path.py 87.87% <42.85%> (-12.13%) ⬇️
tests/test_path.py 83.78% <45.45%> (-16.22%) ⬇️
src/_pytask/collect.py 96.96% <76.92%> (-2.22%) ⬇️
tests/test_collect.py 91.02% <77.41%> (-8.98%) ⬇️
src/_pytask/nodes.py 96.91% <80.00%> (-0.61%) ⬇️
src/_pytask/config.py 97.59% <100.00%> (+0.18%) ⬆️
src/_pytask/resolve_dependencies.py 100.00% <100.00%> (ø)
tests/test_nodes.py 93.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ae5f3...258c488. Read the comment docs.

@tobiasraabe tobiasraabe changed the title Raise warning if paths are not correctly cased on case-insensitive file systems. Raise error if paths are not correctly cased on case-insensitive Windows. Apr 14, 2021
@tobiasraabe tobiasraabe merged commit 7f04fc9 into main Apr 14, 2021
@tobiasraabe tobiasraabe deleted the raise-warning-on-case-insensitive-systems branch April 14, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant