Remove python3.5 support #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinche
requested changes
Oct 6, 2020
README.rst
Outdated
| @@ -178,6 +165,7 @@ Changelog | |||
| 0.15.0 (UNRELEASED) | |||
| ~~~~~~~~~~~~~~~~~~~ | |||
| - Add support for Python 3.9 | |||
| - Abandon support for Python 3.5 | |||
There was a problem hiding this comment.
Just add a note here instructing users to use a lower version if they need 3.5 support :)
There was a problem hiding this comment.
Sure! I adjusted the Changelog accordingly. Let me know what you think.
This commit: - Removes Python 3.5 from the tested environments in CI and tox - Removes instructions specific to Python 3.5 from the README - Updates the Changelog - Removes the dependency on async_generator - Removes instructions in conftest that skip certain test cases if the Python version is smaller than 3.6 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
The test cases in this module are duplicates of test_simple.py, except for test_async_close_loop which was moved to test_simple.py. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Test modules suffixed with "_35" or "_36" give the impression that they are specific to a Python version. This is no longer the case, though. The renamed modules are not specific to any Python version. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
remove-python3.5-support
branch
from
3c2738e to
bd6194f
Compare
|
Cool, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #191.
This PR removes support for Python 3.5 and consists of three commits:
async_generatorlibrary.test_simple_35andtest_simple_35and_36suffixes from test module names. Test modules with these suffixes give the impression that they are associated with a certain Python version. This is no longer the case.