6.1.1: pytest still needs `setooptools`

[kloczek]

Despite fact that latest version has been mopved from setuptools to poetry pytest still needs setuptools (more precise pkg_resources which is parft of the setuptools)

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-bdd-6.1.1-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-bdd-6.1.1-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.15, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/pytest-bdd-6.1.1, configfile: pytest.ini, testpaths: tests
plugins: bdd-6.1.1
collected 107 items / 1 error

================================================================================== ERRORS ==================================================================================
_______________________________________________________________ ERROR collecting tests/feature/test_tags.py ________________________________________________________________
ImportError while importing test module '/home/tkloczko/rpmbuild/BUILD/pytest-bdd-6.1.1/tests/feature/test_tags.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/feature/test_tags.py:4: in <module>
    import pkg_resources
E   ModuleNotFoundError: No module named 'pkg_resources'
========================================================================= short test summary info ==========================================================================
ERROR tests/feature/test_tags.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================= 1 error in 0.27s =============================================================================

[kloczek]

Just tested and despite that one details pytest after add setuptools to build env is perfectly fine

+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.15, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/pytest-bdd-6.1.1, configfile: pytest.ini, testpaths: tests
plugins: bdd-6.1.1
collected 119 items

tests/test_hooks.py ...                                                                                                                                              [  2%]
tests/args/test_common.py ..                                                                                                                                         [  4%]
tests/args/cfparse/test_args.py ..                                                                                                                                   [  5%]
tests/args/parse/test_args.py ..                                                                                                                                     [  7%]
tests/args/regex/test_args.py ..                                                                                                                                     [  9%]
tests/feature/test_alias.py .                                                                                                                                        [ 10%]
tests/feature/test_background.py ..                                                                                                                                  [ 11%]
tests/feature/test_cucumber_json.py .                                                                                                                                [ 12%]
tests/feature/test_description.py .                                                                                                                                  [ 13%]
tests/feature/test_feature_base_dir.py .......                                                                                                                       [ 19%]
tests/feature/test_gherkin_terminal_reporter.py ............                                                                                                         [ 29%]
tests/feature/test_multiline.py .....                                                                                                                                [ 33%]
tests/feature/test_no_scenario.py .                                                                                                                                  [ 34%]
tests/feature/test_no_sctrict_gherkin.py ..                                                                                                                          [ 36%]
tests/feature/test_outline.py ....                                                                                                                                   [ 39%]
tests/feature/test_outline_empty_values.py .                                                                                                                         [ 40%]
tests/feature/test_report.py .s                                                                                                                                      [ 42%]
tests/feature/test_same_function_name.py .                                                                                                                           [ 42%]
tests/feature/test_scenario.py ..............                                                                                                                        [ 54%]
tests/feature/test_scenarios.py ........                                                                                                                             [ 61%]
tests/feature/test_steps.py ..........                                                                                                                               [ 69%]
tests/feature/test_tags.py ............                                                                                                                              [ 79%]
tests/feature/test_wrong.py .                                                                                                                                        [ 80%]
tests/generation/test_generate_missing.py ...                                                                                                                        [ 83%]
tests/library/test_parent.py .....                                                                                                                                   [ 87%]
tests/scripts/test_generate.py ...                                                                                                                                   [ 89%]
tests/scripts/test_main.py .                                                                                                                                         [ 90%]
tests/scripts/test_migrate.py .                                                                                                                                      [ 91%]
tests/steps/test_common.py .......                                                                                                                                   [ 97%]
tests/steps/test_given.py .                                                                                                                                          [ 98%]
tests/steps/test_unicode.py ..                                                                                                                                       [100%]

========================================================================= short test summary info ==========================================================================
SKIPPED [1] tests/feature/test_report.py:260: Execnet not installed
===================================================================== 118 passed, 1 skipped in 16.41s ======================================================================

[youtux]

We should use importlib instead of pkg_resources.
I'll make a fix in the weekend.

Thanks for reporting this.

[The-Compiler]

Given that pytest-bdd 6.1.0 requires pytest 6.2, that check for pytest 6.2 (which is the only place it's used) can just be dropped entirely:

pytest-bdd/tests/feature/test_tags.py

Lines 239 to 245 in d3e8407

	# Deprecate --strict after pytest 6.1
	# https://docs.pytest.org/en/stable/deprecations.html#the-strict-command-line-option
	pytest_version = pkg_resources.get_distribution("pytest").parsed_version
	if pytest_version >= pkg_resources.parse_version("6.2"):
	strict_option = "--strict-markers"
	else:
	strict_option = "--strict"

[kloczek]

Tested and it is ok now with that commit.
Thank you 👍