Skip to content

Conversation

bubenkoff
Copy link
Member

closes #118. closes #119

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling a7272be on pytest-dev:parametrize_strict_gherkin into dfa962e on pytest-dev:master.

olegpidsadnyi added a commit that referenced this pull request Jun 16, 2015
Make it possible to relax strict Gherkin scenario validation
@olegpidsadnyi olegpidsadnyi merged commit c4c9c34 into master Jun 16, 2015
@bubenkoff bubenkoff deleted the parametrize_strict_gherkin branch June 16, 2015 14:33
@lrowe
Copy link
Contributor

lrowe commented Jun 18, 2015

This doesn't work when the pytestbdd_strict_gherkin fixture is set in a conftest.py.

@lrowe
Copy link
Contributor

lrowe commented Jun 18, 2015

It also doesn't work with the scenarios helper when the fixture is in the test file.

@lrowe
Copy link
Contributor

lrowe commented Jun 18, 2015

Also needs to handle steps in background.

@bubenkoff
Copy link
Member Author

my god, so your background contains something else than given?

@bubenkoff
Copy link
Member Author

what's your code, please show the structure

@lrowe
Copy link
Contributor

lrowe commented Jun 19, 2015

Currently we have a feature like this:

Feature: Search
    Background:
        When I visit "/search"
        And I wait for the content to load

    Scenario: Search
        Then the title should contain the text "Search"

    Scenario: Search Antibodies
        When I click the link with text that contains "Data"
        And I click the link to "/search/?type=antibody_lot"
        And I wait for the content to load
        Then I should see at least 15 elements with the css selector "ul.nav.result-table > li"
        And I should see at least 5 elements with the css selector "div.box.facets > div.facet"
        ...

@bubenkoff
Copy link
Member Author

fixed in 2.12.1 please check

@lrowe
Copy link
Contributor

lrowe commented Jun 19, 2015

My tests still fail with 2.12.1 because the pytestbdd_strict_gherkin fixture is not respected when using scenarios.

@bubenkoff
Copy link
Member Author

Right, sorry i forgot to fix that as well. Will do today

@bubenkoff
Copy link
Member Author

2.12.2 is out, please try

@lrowe
Copy link
Contributor

lrowe commented Jun 22, 2015

Thanks @bubenkoff. This is now working for me with the scenarios helper and the fixture in conftest.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allowing when steps to follow then steps?

4 participants