Catch2: support v3 #115
Catch2: support v3 #115
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
This looks great @jnewb1, thanks! Can you please also add a CHANGELOG entry?
src/pytest_cpp/catch2.py
Outdated
| cls, | ||
| executable: str, | ||
| harness_collect: Sequence[str] = (), | ||
| ) -> bool: | ||
| ) -> Optional[str]: |
There was a problem hiding this comment.
If we want to type this correctly, we can either use an enum, or Literal:
| ) -> Optional[str]: | |
| ) -> Optional[Literal["v2", "v3"]]: |
src/pytest_cpp/catch2.py
Outdated
| @@ -123,11 +148,16 @@ def run_test( | |||
| return [failure], output | |||
|
|
|||
| def _parse_xml( | |||
| self, xml_filename: str | |||
| self, xml_filename: str, catch_version: str | |||
There was a problem hiding this comment.
| self, xml_filename: str, catch_version: str | |
| self, xml_filename: str, catch_version: Literal["v2", "v3"] |
|
@jnewb1 this is your 2nd high-quality PR to this repository, would you like to be added as a maintainer? It would not entail much more responsibility, but it would give you permission to also review other PRs and handle issues (this is a low volume repository). |
sure, you can add me as a maintainer! |
Awesome! Sent you an invite. 👍 |
original work from: #107