Catch2: handle exceptions #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
nicoddemus
reviewed
Sep 16, 2023
nicoddemus
approved these changes
Sep 16, 2023
nicoddemus
reviewed
Sep 16, 2023
|
Thanks @jnewb1, great work! Do you have more Catch2 work in the horizon? If not, feel free to kick off a new release (see RELEASING.md.). |
I'm mostly fixing them as I run into them in openpilot. I don't think it handles when the test crashes and doesn't make the xml. Going to fix that, then we can cut the release |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions are a separate output in the XML from normal failures