Skip to content

Screenshots does not work with non-session scoped browsers #74

@pelme

Description

@pelme

When using --splinter-session-scoped-browser=false, the failure screenshot does not work. The browser gets shut down before the screenshot takes place.

There is no explicit dependency on the browser instance in browser_screenshot. It just looks at the requested fixtures and gets the browser. However, the browser instance may already have been shut down at the time when the screenshot capture happens.

I have a PR forthcoming.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions