Handle urlerror in make screenshot on failure

[blueyed]

Fixes #16.

[coveralls]

Coverage decreased (-1.98%) to 71.13% when pulling 1562d1c on blueyed:handle-urlerror-in-make_screenshot_on_failure into eae87cc on pytest-dev:master.

[bubenkoff]

not sure if you need logging, and if you do, then it definitely should be not info but debug?

[blueyed]

It won't / should not affect production systems / logs, but is used only during tests - and in that case it's a good/useful information.

[bubenkoff]

agreed, then modernize it - use .format

[blueyed]

I've pushed a new commit, and added a test.

Is it possible for the test to not spawn a browser window, like with the other tests in tests/test_screenshot.py?
I had to use testdir.runpytest to get the actual output from py.test.
Could this be achieved using testdir.inline_runsource, too?

[coveralls]

Coverage decreased (-1.47%) to 71.65% when pulling 4e688ef on blueyed:handle-urlerror-in-make_screenshot_on_failure into eae87cc on pytest-dev:master.

[blueyed]

i think if you'll patch .warn on pytest it should be good enough

That wasn't trivial - I hope I got it right?!

Let me know if this is good, and I'll squash-merge it as a single commit into master.

[bubenkoff]

assertion should be moved out inside of the 'root' test, then it will be ok

[blueyed]

I've tried that first, but it did not work - the warning gets done in the inner test.

I've committed it in 008728f, and added an sentence to the doc.

[coveralls]

Coverage decreased (-1.47%) to 71.65% when pulling c5cb90d on blueyed:handle-urlerror-in-make_screenshot_on_failure into 1e058c8 on pytest-dev:master.

[bubenkoff]

please change back, it decreases the coverage, also the readability - those multiple returns in a single function

[bubenkoff]

what's your username on pypi?

[bubenkoff]

actually i've just found out that test is a complete false-positive thing
when you use mock as decorator, you should receive it as argument as well, instead your testdir is the mock so it just accepts everything :)

[bubenkoff]

i think i'll fix it myself

[bubenkoff]

ok i fixed it
please give a bit more love to the code next time

[bubenkoff]

1.2.10 is out

[blueyed]

Thanks for fixing (and releasing) it, and sorry for my oversights.