Skip to content

use tmpdir_factory to get session scoped tmpdir #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2016
Merged

use tmpdir_factory to get session scoped tmpdir #67

merged 1 commit into from
Jul 16, 2016

Conversation

bubenkoff
Copy link
Member

@bubenkoff bubenkoff commented Jul 13, 2016 •
edited
Loading

fixes #66

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.742% when pulling bf46c0b on localize-tmpdir-usage into a475555 on master.

@olegpidsadnyi
Copy link
Contributor

LGTM

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@olegpidsadnyi
Copy link
Contributor

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bubenkoff bubenkoff merged commit 1db679f into master Jul 16, 2016
@bubenkoff bubenkoff deleted the localize-tmpdir-usage branch July 16, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

@bubenkoff bubenkoff

@olegpidsadnyi olegpidsadnyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate tmpdir fixtures causes --fixtures sorting logic to fail
4 participants
@bubenkoff @coveralls @olegpidsadnyi @RonnyPfannschmidt