Fixed issue shadowing error when missing argument on teardown_method #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -6,7 +6,8 @@ | |||
| * Text documents without any doctests no longer appear as "skipped". | |||
| Thanks `@graingert`_ for reporting and providing a full PR (`#1580`_). | |||
|
|
|||
| * | |||
| * Fix internal error issue when `method` argument is missing for | |||
| `teardown_method`. Fixes (`#1605`). | |||
There was a problem hiding this comment.
Some small ReST issues with this:
- Use double backticks for monospace
- Probably want to drop the parens
- You'll need to add
#1605to the link list further down
There was a problem hiding this comment.
ok, I'm not really used to ReST, got a strong preference for markdown syntax. BTW, I mimicked the syntax around.
When the method argument is missing on teardown_method, the traceback is 100% internal to pytest, which with default options get pruned. Then that traceback is empty, leading to a new exception as a traceback shall not be empty. This PR fixes that issue by pushing back the last stack on the traceback, when the stacktrace is empty after pruning. Then the output is still pruned, but gives meaningful information with the item where it failed on the stack. * fixes issue pytest-dev#1604 Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
This was referenced Aug 19, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the method argument is missing on teardown_method, the traceback is
100% internal to pytest, which with default options get pruned. Then
that traceback is empty, leading to a new exception as a traceback shall
not be empty.
This PR fixes that issue by pushing back the last stack on the
traceback, when the stacktrace is empty after pruning. Then the output
is still pruned, but gives meaningful information with the item where it
failed on the stack.
methodargument ofteardown_method, gettingINTERNALERROR#1604