Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finally drop python2.6 support #2812

Closed
RonnyPfannschmidt opened this issue Oct 3, 2017 · 7 comments
Closed

finally drop python2.6 support #2812

RonnyPfannschmidt opened this issue Oct 3, 2017 · 7 comments
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog

Comments

@RonnyPfannschmidt
Copy link
Member

i just verified with @dstufft that pip master no longer supports python2.6 and we can drop it for all purposes

@RonnyPfannschmidt RonnyPfannschmidt added type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: task labels Oct 3, 2017
@RonnyPfannschmidt RonnyPfannschmidt changed the title finally drop pytohn2.6 support finally drop python2.6 support Oct 3, 2017
@obestwalter
Copy link
Member

Is a release of pip 10 in sight then? Last time I checked I found a comment by @dstuff that there is no ETA.

@nicoddemus
Copy link
Member

I thought we would wait for the actual release of pip 10 no?

@nicoddemus
Copy link
Member

Btw, should we drop 3.3 at the same time?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus yup wrt 3.3

@nicoddemus wrt release waiting, the work time spend on pip ha been reduced, so its in need of more volunteer work as well,

as such i think for pytest its reasonable to change before the release,
with a bit of luck pips release wil be before our next feature release

@hugovk
Copy link
Member

hugovk commented Oct 4, 2017

Here's a reference to pip dropping 2.6: pypa/pip#3955

Here's the last few issues remaining for pip 10: https://github.com/pypa/pip/milestone/23

Here's the earlier PR to drop it here: #2031

@dstufft
Copy link

dstufft commented Oct 4, 2017

FWIW we don't run tests against old versions of pip really, so it's pretty much just the master branch that matters, and it doesn't run against 2.6 now.

@RonnyPfannschmidt
Copy link
Member Author

since attrs doesnt support 2.6 i#ll take a stake at working this one out - i want attrs asap in pytest ^^

omgjlk added a commit to omgjlk/github3.py that referenced this issue Dec 14, 2017
Ran into these in an unrelated PR.

Don't have a bare except

Don't use single char variables

Drop py33 testing, that release is no longer supported by pytest and
they are EOL upstream as well.
( pytest-dev/pytest#2812 )

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
omgjlk added a commit to omgjlk/github3.py that referenced this issue Dec 14, 2017
Ran into these in an unrelated PR.

Don't have a bare except

Don't use single char variables

Drop py33 testing, that release is no longer supported by pytest and
they are EOL upstream as well.
( pytest-dev/pytest#2812 )

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog
Projects
None yet
Development

No branches or pull requests

5 participants