(chore):refactor-offchain-guide #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aditya520
commented
May 15, 2024
jayantk
approved these changes
May 15, 2024
|
|
||
| ## Usage | ||
|
|
||
| Typical usage of the Pyth SDK involves creating a `PriceServiceConnection` instance, and using it to fetch prices. |
There was a problem hiding this comment.
I think this sentence should additionally explain that the typescript SDK connects to the Hermes service.
More general comment here is that the reader doesn't hear about hermes until the end where it says hermes API reference. Seems like Hermes should be mentioned at least once early on in the doc. We don't have to describe everything about Hermes, but we should at least say that you fetch price updates from Hermes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.