Added clarity on chain id and fixed cast send argument #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chain ID used on the api is not the EVM chain id so it might be a bit misleading, I added description. The `cast send` call had a bad argument, modified that.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GabrielCartier is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
jayantk
approved these changes
Nov 28, 2024
|
thank you @GabrielCartier for contributing these fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain ID used on the api is not the EVM chain id so it might be a bit misleading, I added an explanation and link to fetch the ids.
The
cast sendcall had a bad argument, modified that.