Improve logging and reliability #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
force-pushed
the
improve-agent
branch
from
3af0faf to
0cdbca5
Compare
Suggested by dependabot
tompntn
approved these changes
Feb 20, 2023
| @@ -32,7 +32,7 @@ async fn main() { | |||
| let logger = slog::Logger::root( | |||
| slog_async::Async::default( | |||
| LogBuilder::new( | |||
| slog_term::CompactFormat::new(slog_term::TermDecorator::new().stdout().build()) | |||
| slog_term::FullFormat::new(slog_term::TermDecorator::new().stdout().build()) | |||
There was a problem hiding this comment.
Just curious - why the change?
There was a problem hiding this comment.
I don't know why it was not showing the key/value passed to it via the parent logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: By default there is a timeout of 30 seconds everywhere but I think it's still good to have it explicit.