Make the default usage check the price status #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
commented
Nov 1, 2021
| @@ -37,7 +37,7 @@ | |||
| "typescript": "^4.2.4" | |||
| }, | |||
| "dependencies": { | |||
| "@solana/web3.js": "^1.10.1", | |||
| "@solana/web3.js": "^1.30.2", | |||
There was a problem hiding this comment.
drive-by: bump the solana web3 version. I fixed a memory leak in the websocket RPC library that solana web3 is using, so bumping this version incorporates that change.
|
@jayantk looks reasonable, given the breaking change you probably want to increment the minor version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been telling users that they need to check the status of the price before consuming it. However, most users are not checking the status field, because our client libraries don't make this easy. I'm changing the default behavior in all of client libraries to do the right thing so that the easiest usage is also correct.
Note that this PR makes a breaking change to the public interface of this library. LMK if you think we should do something special to warn users about this breaking change before we release this.