Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Deprecate crate #23

Merged
merged 7 commits into from
May 3, 2022
Merged

Deprecate crate #23

merged 7 commits into from
May 3, 2022

Conversation

ali-behjati
Copy link
Contributor

No description provided.

Apparently badge doesn't show in ui. So I needed to add in readme too
@ali-behjati ali-behjati requested review from jayantk and Reisen May 2, 2022 13:33
Copy link
Collaborator

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if you need to deprecate the individual methods or not. aside from that lgtm

Copy link

@Reisen Reisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out you can deprecate the whole file in one swoop using a top-level #![deprecated], I think rather than cherry picking some functions as is currently here the single top-level can be added instead.

@ali-behjati ali-behjati requested review from Reisen and jayantk May 2, 2022 16:13
@ali-behjati ali-behjati requested a review from Reisen May 3, 2022 09:26
@ali-behjati ali-behjati merged commit 6849b39 into main May 3, 2022
@ali-behjati ali-behjati deleted the abehjati/deprecate-crate branch May 3, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants