Add batch price update instruction to Oracle #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
force-pushed
the
oracle-batch-upd-price
branch
4 times, most recently
from
c53b763 to
62d85c8
Compare
jayantk
previously approved these changes
Feb 10, 2022
program/src/oracle/oracle.c
Outdated
| } | ||
|
|
||
| // Verify that the correct number of accounts have been passed | ||
| if ( (prm->ka_num != 3 && prm->ka_num != 4) ) { |
There was a problem hiding this comment.
(not related to this change) would you happen to know why this lets you submit 4 accounts ? seems like a weird feature.
There was a problem hiding this comment.
Good question - I'm not sure. AFAICT pythd only ever sends 3 accounts, and the Oracle program doesn't ever use the 4th one. I can't see anywhere this is used, but maybe I'm missing something.
There was a problem hiding this comment.
I think an old version of the onchain program took a 'parameter' account which was removed in cd9dc8c
tompntn
force-pushed
the
oracle-batch-upd-price
branch
from
faf49d1 to
c3d96c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new instruction to the Oracle:
cmd_upd_price_no_fail_on_error. This is exactly the same ascmd_upd_price, but never fails the instruction, and therefore the transaction, even if the update is unsuccessful. This is because we will soon send update instructions in batches, and want to prevent a failure in one price feed blocking updates of other prices.Approach
cmd_upd_price_no_fail_on_errorinstruction.pythdto sendcmd_upd_price_no_fail_on_errorJPRC requests instead ofcmd_upd_price.Testing
pythdchanges: the existingpythdintegration tests for the JRPCupdate_pricerequest will now cover the newe_cmd_upd_price_no_fail_on_errorcode paths.cmd_upd_price_no_fail_on_errorinstructions have been added, demonstrating the optimistic failure semantics.Caveats
All price update transactions will appear on-chain, even if they are unsuccessful. This means publishers will have to rely on inspecting publishing slots to be sure if their updates were successful.