Store value of previous price aggregate if the status is trading #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is always 1 for all currently deployed price accounts which have had upd_ema ran once, which covers all accounts. Therefore the condition inside upd_ema will always be true. We can therefore remove the usage of drv1_, freeing it up to be used for other 64-bit data in the future.
for consistency. This effectively makes prev_slot_, prev_price_ and prev_conf_ a cache of the ptr->agg_ fields.
… status is UNKNOWN
jayantk
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics of the
pc_price.prev_slot_,pc_price.prev_price_andpc_price.prev_conf_fields to only store the value of the previous price aggregate if the previous price aggregate had a status of TRADING. We also store a new piece of data, the Solana unix timestamp of this previous aggregate, for convenience.