Skip to content

Rust entrypoint #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 7, 2022
Merged

Rust entrypoint #184

merged 18 commits into from
Jul 7, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Jul 5, 2022 •
edited
Loading

Moves the contract entrypoint to rust_entrypoint/src/lib.rs. Thanks @majabbour !!

guibescos
guibescos commented Jul 5, 2022
View reviewed changes
guibescos
guibescos commented Jul 5, 2022
View reviewed changes
guibescos
guibescos commented Jul 5, 2022
View reviewed changes
guibescos
guibescos commented Jul 5, 2022
View reviewed changes
@guibescos guibescos marked this pull request as ready for review July 5, 2022 22:26
tompntn
tompntn suggested changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@tompntn tompntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@majabbour majabbour requested a review from tompntn July 6, 2022 17:50
guibescos
guibescos commented Jul 6, 2022
View reviewed changes
Copy link
Contributor Author

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

tompntn
tompntn previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@tompntn tompntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jayantk
jayantk previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@majabbour majabbour dismissed stale reviews from jayantk and tompntn via 3bbb4ba July 6, 2022 22:00
@majabbour majabbour merged commit aea724a into main Jul 7, 2022
@majabbour majabbour deleted the rust-entrypoint branch July 7, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk left review comments

+2 more reviewers

@majabbour majabbour majabbour approved these changes

@tompntn tompntn tompntn left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guibescos @jayantk @tompntn @majabbour