Borsch traits using bindgen #196
Conversation
majabbour
force-pushed
the
borsch-traits-using-bindgen
branch
from
1fcd5ae to
126d497
Compare
program/rust/build.rs
Outdated
| ])}; | ||
|
|
||
| //generate and write bindings | ||
| let bindings = bindgen::Builder::default().header("./src/bindings.h").parse_callbacks(Box::new(parser)).generate().expect("Unable to generate bindings"); |
There was a problem hiding this comment.
nitpic: would be good to run rustfmt on all Rust code in this repo as part of the CI/CD to get consistent formatting.
There was a problem hiding this comment.
oh sorry I have not been doing that for the code I have been pushing, I should probably make a different PR with just cargo fmt after merging this/ other outstanding rust PRs. Otherwise git diff might be confusing
There was a problem hiding this comment.
I added a all to fmt in to the Builder in build.rs. Did not seem to change how bindings.rs lookd much, but I do not think it's a big problem since you should never have to read it (because it just redefines stuff in oracle.h).
I will start calling cargo fmt on every commit once we make that fmt PR
majabbour
force-pushed
the
borsch-traits-using-bindgen
branch
2 times, most recently
from
22d2ce1 to
2a8e45e
Compare
|
|
||
| let borsh_derives: Vec<String> = vec!["BorshSerialize".to_string(), "BorshDeserialize".to_string()]; | ||
|
|
||
| //make a parser and to it type, traits pairs |
There was a problem hiding this comment.
i think people usually put a space after the // and before the text. Actually I'm kind of surprised that rustfmt doesn't fix this for you.
There was a problem hiding this comment.
yes, sorry noob Rust developer here. Forgot to run cargo fmt. Once this and the other PR are approved, I will do it in a seperate PR that is just fmt. (and then run it after every commit).
If I run it now the diffs will probably be confusing for reviewers.
There was a problem hiding this comment.
Looks good to me -- definitely better to rely on rust to add these traits. I'll let @guibescos give you the final approval though.
| mod c_oracle_header; | ||
|
|
||
| //Below is a high lever description of the rust/c setup. |
There was a problem hiding this comment.
🙇 for writing documentation explaining how this works.
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
force-pushed
the
borsch-traits-using-bindgen
branch
from
4697f3b to
5871ab8
Compare
We need to derive Borsh traits to C bindings, so I changed build.rs to include a map from type names to traits that we can use to add traits to types in the C bindings. I included the output file in c_oracle_header.rs below imports needed to define the added traits.