Syncing account sizes between c and rust #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
previously approved these changes
Jul 21, 2022
Co-authored-by: Tom Pointon <tom@teepeestudios.net>
tompntn
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While our C code does not need to directly interact with SMA trackers/ other rust objects. They need to know their sizes to check that the account is rent free, and to anticipate the right account size in pythd.
In this PR, I define the size as a constant in oracle.h, and I add a unit test in Rust that checks that the size is correct (to make sure that the dockerimage does not build if the size is not correct).