Skip to content

Clippy #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 3, 2022
Merged

Clippy #218

merged 21 commits into from
Aug 3, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 2, 2022 •
edited
Loading

Enable clippy CI + precommit hook.

@guibescos guibescos marked this pull request as ready for review August 3, 2022 14:33
majabbour
majabbour approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@majabbour majabbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you test if this catches the unrpropagated error issue in the other PR?

@guibescos
Copy link
Contributor Author

LGTM, did you test if this catches the unrpropagated error issue in the other PR?

It does

@guibescos guibescos merged commit d8e3fa2 into main Aug 3, 2022
@guibescos guibescos deleted the clippy branch August 3, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

@majabbour majabbour majabbour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guibescos @jayantk @majabbour