Rust/add publisher #229
Merged
Rust/add publisher #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
reviewed
Aug 8, 2022
program/rust/src/rust_oracle.rs
Outdated
| ) -> OracleResult { | ||
| let cmd_args = load::<cmd_add_publisher_t>(instruction_data)?; | ||
|
|
||
| if instruction_data.len() != size_of::<cmd_add_publisher_t>() || pubkey_is_zero(&cmd_args.pub_) |
There was a problem hiding this comment.
use pyth_assert for these checks
program/rust/src/rust_oracle.rs
Outdated
| return Err(ProgramError::InvalidArgument); | ||
| } | ||
|
|
||
| let [_funding_account, price_account] = match accounts { |
There was a problem hiding this comment.
_ prefix indicates the variable isn't used later in the function, but _funding_account is
| return Err(ProgramError::InvalidArgument); | ||
| } | ||
|
|
||
| for i in 0..(price_data.num_ as usize) { |
There was a problem hiding this comment.
(i'm going to look at whether we can override some of the field definitions in the struct so they're usize instead of u32 so we don't have to do these casts all the time)
jayantk
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding publishers in rust.