Skip to content

Rust/more tests #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 10, 2022
Merged

Rust/more tests #234

merged 23 commits into from
Aug 10, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 9, 2022 •
edited
Loading

New test for add_price and c test migrated for add_publisher.
Also adding size_ checks to previous tests.

@guibescos guibescos changed the base branch from main to traits2 August 9, 2022 20:38
@guibescos guibescos marked this pull request as ready for review August 9, 2022 21:40
jayantk
jayantk previously approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Base automatically changed from traits2 to main August 10, 2022 14:56
@guibescos guibescos merged commit 94e9954 into main Aug 10, 2022
@guibescos guibescos deleted the rust/more-tests branch August 10, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guibescos @jayantk