Implement init_price instruction #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
commented
Aug 10, 2022
| unsafe impl Pod for pc_ema { | ||
| } | ||
|
|
||
| #[cfg(target_endian = "little")] |
There was a problem hiding this comment.
this was missing before for some reason
guibescos
reviewed
Aug 11, 2022
guibescos
reviewed
Aug 11, 2022
| instruction_data: &[u8], | ||
| ) -> OracleResult { | ||
| let cmd_args = load::<cmd_init_price_t>(instruction_data)?; | ||
|
|
There was a problem hiding this comment.
The check that instruction_data.len() == size_of::<cmd_init_price_t>(cmd_init_price) went away because load will work as long as instruction_data.len() >= size_of::<cmd_init_price_t>(cmd_init_price)
There was a problem hiding this comment.
Just flagging the differences with C, I think this is acceptable.
guibescos
reviewed
Aug 11, 2022
| Err(ProgramError::InvalidArgument) | ||
| ); | ||
|
|
||
| price_account.is_signer = false; |
There was a problem hiding this comment.
I think you meant to make this true
guibescos
reviewed
Aug 11, 2022
jayantk
commented
Aug 11, 2022
| SolPubkey_same( ka->owner, prm->program_id ) && | ||
| ka->data_len >= min_dlen && | ||
| is_rent_exempt( *ka->lamports, ka->data_len ); | ||
| } |
There was a problem hiding this comment.
no longer used, and the c build fails if you have unused functions
guibescos
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.