Skip to content

Cleanup entrypoint #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 19, 2022
Merged

Cleanup entrypoint #258

merged 16 commits into from
Aug 19, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Aug 18, 2022

Switch to using solana provided entrypoint macro.

@guibescos guibescos changed the title Cleanup Cleanup entrypoint Aug 18, 2022
Copy link
Contributor

@tompntn tompntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. you are free to ignore the logging comment and merge if you’d like.

let (program_id, accounts, instruction_data) = unsafe { deserialize(input) };

#[cfg(feature = "debug")]
if let Err(error) = pre_log(&accounts, instruction_data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you lost the debug logging feature here. maybe copy this code into processor ?

@guibescos guibescos merged commit 639af13 into main Aug 19, 2022
@guibescos guibescos deleted the cleanup branch August 19, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants