Make it build on macs #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
commented
Aug 19, 2022
| @@ -9,6 +9,7 @@ fn main() { | |||
|
|
|||
| //generate and write bindings | |||
| let bindings = Builder::default() | |||
| .clang_arg("-I../../../solana/sdk/bpf/c/inc/") | |||
There was a problem hiding this comment.
required to make bindgen find the solana header files.
hardcoding this path is obviously bizarre. however, the C makefile already does this, so I'm not making the situation any worse.
guibescos
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cargo build (and
./scripts/build-bpf.sh) used were failing because we were defining these integer types multiple times. It turns out that we already have a solution to this problem incompat_stdint.hwhich selects between the system stdint.h and the definitions in the solana sdk.Note that the repo still expects to be placed adjacent to a
solanadirectory. I'll fix that next.