Command to delete a product #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2022 08:57
guibescos
reviewed
Aug 22, 2022
Reisen
reviewed
Aug 22, 2022
| let product_data = load_checked::<pc_prod_t>(product_account, cmd_args.ver_)?; | ||
|
|
||
| // This assertion is just to make the subtractions below simpler | ||
| pyth_assert(mapping_data.num_ >= 1, ProgramError::InvalidArgument)?; |
There was a problem hiding this comment.
Rather than assert, can we used .checked_sub on the subtractions below? We can (and should) enable clippy’s arithmetic lint which will be safer. We should really be using checked arithmetic for everything on-chain.
There was a problem hiding this comment.
good call on the arithmetic checks. will enable in a separate pr.
guibescos
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is again needed to clean up the pythtest situation, where we created extra product/price accounts.