Make requested CU amount and price in upd_price transactions configurable in pythd #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompntn
force-pushed
the
pythd-configurable-tx-price
branch
from
072fa03 to
58b547b
Compare
tompntn
force-pushed
the
pythd-configurable-tx-price
branch
from
cc1e6f1 to
5814705
Compare
jayantk
previously approved these changes
Nov 17, 2022
jayantk
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows publishers to configure the amount and cost of CU units used in
upd_pricetransactions. By default we specify the amount, but not the cost.Note that one code path, that used by the
pyth upd_price_valcli command, used only in tests, uses a slightly different method of sending the transaction than the websocketupdate_pricecommand. To ensure this still works, we preserve the signatures of the existingpc::rpc::upd_price::buildandpc::rpc::upd_price::requestmethods, instead adding additional versions of these that allow specifying the additional parameters.