Remove bincode #314
Merged
Remove bincode #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
remove-bincode
branch
from
9fc17fb to
c3d3e9d
Compare
jayantk
approved these changes
Nov 24, 2022
| programdata_deserialized | ||
| .upgrade_authority | ||
| .eq(upgrade_authority_account.key) | ||
| && programdata_deserialized.account_type == 3 |
There was a problem hiding this comment.
what’s the account type check mean? (maybe leave a comment)
There was a problem hiding this comment.
could also considering extracting 3 out into a constant somewhere with a descriptive name
There was a problem hiding this comment.
ProgramdataAccount comments explain this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bincode. We are forced to use bytemuck to deserialize the programdata account.
This a big size gain : 170k -> 99k