Fix solana dir #318
Merged
Fix solana dir #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
previously approved these changes
Nov 28, 2022
|
oh can you take a look at the docs and update anything about the side-by-side solana dir? |
guibescos
force-pushed
the
guibescos/fix-solana-dir
branch
from
9605d92 to
0a3add5
Compare
|
Updated docs and all the other places where the path of solana was needed |
jayantk
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is fixing an annoying quirk of the repo that meant you had to the
pyth_clientrepo and thesolanarepo side to side in the same folder. The trick is we can find the solana local installation by doingwhich cargo-build-bpf. This is inspired by https://github.com/guibescos/example-helloworld .Resolving the solana installation ended up a little bit dirty in
build.rsbecause bindgen needs to find the solana C headers. This will get better when we get rid of the C headers.