Skip to content

Use custom bpf-tools #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Use custom bpf-tools #319

merged 4 commits into from
Nov 29, 2022

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Nov 28, 2022

With the current solana-labs bpf-tools (the toolchain that builds bpf programs), the flags -Z build-std=std,panic_abort don't work. These flags compile the standard rust library from scratch and make the program smaller.

There is evidence that the solana team plans to release a version that support this : https://github.com/solana-labs/solana/blob/9f370475d40dbe68f1a51d34fc3df07e5327d6c3/sdk/cargo-build-sbf/src/main.rs#L625

This PR is meant to make the repo use a fork of bpf-tools instead of the solana-labs release. The only difference between the my fork and solana-labs is that my fork uses https://github.com/solana-labs/compiler-builtins/tree/sbf-tools-v1.30 instead of https://github.com/solana-labs/compiler-builtins/tree/bpf-tools-v1.27 (a package bump basically) .

TLDR : I think the solana team is gonna make a release eventually enabling what I want to do (the changes have made it to the master branch of solana but not the releases yet) but I don't really want to wait.

@guibescos guibescos marked this pull request as ready for review November 28, 2022 19:51
Copy link

@ptaffet ptaffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider moving these repos out of guibescos if Solana takes a long time to merge these, but for now this looks good to me

@guibescos guibescos merged commit 8442f2f into main Nov 29, 2022
@guibescos guibescos deleted the guibescos/use-custom-bpf-tools branch November 29, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants