[pyth_oracle] Allow add_product to create product metadata #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
changed the title
guibescos
force-pushed
the
guibescos/refactor
branch
2 times, most recently
from
18dea3f to
5698c78
Compare
jayantk
previously approved these changes
Jan 31, 2023
| @@ -83,5 +84,7 @@ pub fn add_product( | |||
| )? + mapping_data.number_of_products | |||
| * try_convert::<_, u32>(size_of::<Pubkey>())?; | |||
|
|
|||
| update_product_metadata(instruction_data, new_product_account, hdr.version)?; | |||
There was a problem hiding this comment.
Document the instruction data format in the doc comment for this function.
jayantk
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now creating a product and adding metadata requires
add_productandupd_product. This PR aims to allow initializing the metadata when you calladd_product.It is backwards compatible. If you call
add_productthe old way, the program will see that as empty metadata so the behavior will be the same as previously.This PR is meant to enable some deterministic keys for product accounts in the future.