[TWAP] Implement new twap #359
Conversation
guibescos
force-pushed
the
revisit-twap2
branch
from
3e228aa to
8cf4cd6
Compare
guibescos
force-pushed
the
revisit-twap2
branch
from
8d52c66 to
caddf96
Compare
guibescos
force-pushed
the
revisit-twap2
branch
from
caddf96 to
a01fb82
Compare
program/rust/src/accounts/price.rs
Outdated
| #[cfg(test)] | ||
| impl PriceAccountNew { | ||
| /// This function gets triggered when there's a succesful aggregation and updates the cumulative sums | ||
| pub fn update_price_cumulative(&mut self) { |
There was a problem hiding this comment.
aren't there some assumptions about trading and stuff that need to be satisfied in order to call this function?
IMO this function does so little it would be better to inline the call to update in the calling code (which also guarantees the assumptions are satisfied)
There was a problem hiding this comment.
The reason it's not inlined is some rust borrower annoyance that makes it not very clean.
I added a check that status == TRADING whenever this function gets called.
| @@ -2,6 +2,7 @@ name: Docker | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ main ] | |||
There was a problem hiding this comment.
Drive-by reduce CI load
| @@ -200,7 +201,7 @@ static_assert( sizeof( pc_price_t ) == 3312, "" ); | |||
|
|
|||
| // This constant needs to be an upper bound of the price account size, it is used within pythd for ztsd. | |||
| // It is set tighly to the current price account + 96 component prices + 48 bytes for cumulative sums | |||
| const uint64_t PRICE_ACCOUNT_SIZE = 3312 + 96 * sizeof( pc_price_comp_t) + 48; | |||
| const uint64_t ZSTD_UPPER_BOUND = 3312 + 96 * sizeof( pc_price_comp_t) + 48; | |||
There was a problem hiding this comment.
This gets renamed for clarity
scripts/check-size.sh
Outdated
| ORACLE_SIZE=$(wc -c ./target/deploy/pyth_oracle.so | awk '{print $1}') | ||
| if [ $ORACLE_SIZE -lt 81760 ] | ||
| if [ $ORACLE_SIZE -lt 88429 ] |
There was a problem hiding this comment.
I think with the c flags we can stay under this with the 3 upcoming changes : twap + resize + message-buffer
program/rust/src/accounts/price.rs
Outdated
|
|
||
| impl PythAccount for PriceAccountV2 { | ||
| const ACCOUNT_TYPE: u32 = PC_ACCTYPE_PRICE; | ||
| /// Equal to the offset of `comp_` in `PriceAccount`, see the trait comment for more detail |
There was a problem hiding this comment.
hm i also just noticed that add_publisher sets the header.size_ field based on the number of populated price components. This field isn't actually read anywhere as far as i know (definitely not used on-chain) but we should fix that too. I think we could just set it to the number of bytes in the account and it'll be fine.
|
This is now blocked by #361 |
No description provided.