[size-hack] Remove clear account #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
May 2, 2023
| @@ -109,7 +113,6 @@ pub trait PythAccount: Pod { | |||
| )?; | |||
|
|
|||
| check_valid_fresh_account(account)?; | |||
| clear_account(account)?; | |||
There was a problem hiding this comment.
maybe worth a code comment that the solana runtime guarantees that the account content is all zero here.
(feel free to do in a later pr because i know the CI takes forever here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to make to program smaller again. This is one idea.
Everytime we create a new account, we manually zero it.
I think this is and has always been unnecessary. Being able to create non-zero accounts belonging to a given program would break solana.