-
Notifications
You must be signed in to change notification settings - Fork 278
Add staking program and mesh program to xc-admin UI #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
"pytS9TjG1qyAZypk7n8rw8gfW9sUaqqYyMhJQ4E7JCQ" | ||
); | ||
|
||
export class AnchorMultisigInstruction implements MultisigInstruction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small refactor here to make it easier to support multiple Anchor programs
24be380
to
b3991f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments
@@ -2,50 +2,76 @@ import { | |||
MultisigInstruction, | |||
MultisigInstructionProgram, | |||
UNRECOGNIZED_INSTRUCTION, | |||
UnrecognizedProgram, | |||
} from "."; | |||
import { AnchorAccounts, resolveAccountNames } from "./anchor"; | |||
import messageBuffer from "message_buffer/idl/message_buffer.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename this messageBufferIdl
to be consistent
default: | ||
return UnrecognizedProgram.fromTransactionInstruction(instruction); | ||
} | ||
const instructionCoder = new BorshCoder(idl as Idl).instruction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need another as Idl
here too?
deserializedData.name, | ||
instruction | ||
) | ||
resolveAccountNames(idl as Idl, deserializedData.name, instruction) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need another as Idl
here too?
This will be useful to review some proposals to transfer authorities to governance and also for adding other Anchor programs in the future.