[hermes] add /v2/updates/price/<timestamp> endpoint #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
cctdaniel
commented
Feb 1, 2024
| @@ -27,7 +27,7 @@ use { | |||
| mod doc_examples; | |||
| mod metrics_middleware; | |||
| mod rest; | |||
| mod types; | |||
| pub mod types; | |||
There was a problem hiding this comment.
reusing PriceUpdate in types for state/benchmarks.rs
cctdaniel
commented
Feb 1, 2024
cctdaniel
commented
Feb 1, 2024
| serde_qs::axum::QsQuery, | ||
| utoipa::IntoParams, | ||
| }; | ||
|
|
||
|
|
||
| #[derive(Debug, serde::Deserialize, IntoParams)] | ||
| #[derive(Debug, Deserialize, IntoParams)] |
There was a problem hiding this comment.
drive-by: refactor
ali-behjati
reviewed
Feb 1, 2024
ali-behjati
reviewed
Feb 1, 2024
hermes/src/state/benchmarks.rs
Outdated
| @@ -56,22 +55,50 @@ impl TryFrom<BinaryBlob> for Vec<Vec<u8>> { | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<BenchmarkUpdates> for PriceFeedsWithUpdateData { | |||
|
|
|||
| impl TryFrom<PriceUpdate> for PriceFeedsWithUpdateData { | |||
There was a problem hiding this comment.
I think this definition should be close to PriceUpdate.
nit: I do have a mixed feeling of having them all in the api module. we could entirely remove PriceFeedsWithUpdateData it it was not necessary for v1 api. Maybe let's move it after we deprecate v1 api.
There was a problem hiding this comment.
hmm should we move it to types.rs instead then?
ali-behjati
approved these changes
Feb 1, 2024
ali-behjati
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.