[hermes] add /v2/price_feeds endpoint #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
cctdaniel
commented
Feb 5, 2024
Comment on lines
+139
to
+153
| filters: Some(vec![RpcFilterType::Memcmp(Memcmp::new( | ||
| 0, // offset | ||
| MemcmpEncodedBytes::Bytes(b"PAS1".to_vec()), // bytes | ||
| ))]), |
There was a problem hiding this comment.
getting
warning: use of deprecated field `solana_client::rpc_filter::Memcmp::offset`: Field will be made private in future. Please use a constructor method instead.
--> src/network/pythnet.rs:140:13
|
140 | offset: 0,
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: use of deprecated field `solana_client::rpc_filter::Memcmp::bytes`: Field will be made private in future. Please use a constructor method instead.
--> src/network/pythnet.rs:141:13
|
141 | bytes: MemcmpEncodedBytes::Bytes(b"PAS1".to_vec()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: use of deprecated field `solana_client::rpc_filter::Memcmp::encoding`: Field has no server-side effect. Specify encoding with `MemcmpEncodedBytes` variant instead. Field will be made private in future. Please use a constructor method instead.
--> src/network/pythnet.rs:142:13
|
142 | encoding: None,
| ^^^^^^^^^^^^^^
possibly due to upgrading solana packages hence the change here to fix the warnings
the new Memcmp::new method does not require an encoding parameter, so we can omit it
impl Memcmp {
pub fn new(offset: usize, encoded_bytes: MemcmpEncodedBytes) -> Self {
Self {
offset,
bytes: encoded_bytes,
encoding: None,
}
}
}
cctdaniel
commented
Feb 6, 2024
| @@ -52,7 +53,7 @@ impl From<PriceIdInput> for PriceIdentifier { | |||
|
|
|||
| type Base64String = String; | |||
|
|
|||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize, ToSchema)] | |||
| #[derive(Debug, Clone, Serialize, Deserialize, ToSchema)] | |||
There was a problem hiding this comment.
drive-by refactors
ali-behjati
reviewed
Feb 6, 2024
ali-behjati
reviewed
Feb 6, 2024
cctdaniel
commented
Feb 7, 2024
| @@ -284,7 +294,7 @@ pub async fn spawn(opts: RunOptions, state: Arc<State>) -> Result<()> { | |||
| }) | |||
| }; | |||
|
|
|||
| let task_guadian_watcher = { | |||
| let task_guardian_watcher = { | |||
Reisen
requested changes
Feb 8, 2024
cctdaniel
force-pushed
the
hermes-v2-price-feeds-metadata
branch
from
a5db5b7 to
9a451c4
Compare
cctdaniel
force-pushed
the
hermes-v2-price-feeds-metadata
branch
from
dc38d38 to
a828c26
Compare
cctdaniel
commented
Feb 17, 2024
Comment on lines
+386
to
+392
| // Split product keys into chunks of 150 to avoid too many open files error (error trying to connect: tcp open error: Too many open files (os error 24)) | ||
| for product_keys_chunk in mapping_acct | ||
| .products | ||
| .iter() | ||
| .filter(|&prod_pkey| *prod_pkey != Pubkey::default()) | ||
| .collect::<Vec<_>>() | ||
| .chunks(150) |
There was a problem hiding this comment.
tried with 200 but still intermittently getting os error 24 so went with 150 to be safe
ali-behjati
reviewed
Feb 19, 2024
ali-behjati
reviewed
Feb 19, 2024
ali-behjati
reviewed
Feb 19, 2024
ali-behjati
reviewed
Feb 19, 2024
ali-behjati
approved these changes
Feb 20, 2024
Reisen
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: support
market_hourswhen the on-chain component is done