fix workflow #1364
Merged
fix workflow #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
reviewed
Mar 15, 2024
| run: | | ||
| poetry -C express_relay/sdk/python/express_relay build | ||
| poetry -C express_relay/sdk/python/express_relay publish --username __token__ --password ${{ secrets.PYPI_TOKEN }} | ||
| cd express_relay/sdk/python/express_relay |
There was a problem hiding this comment.
I think it's better to use working-directory like here https://github.com/pyth-network/pyth-crosschain/blob/main/.github/workflows/publish-pyth-sdk-cw.yml#L18
guibescos
reviewed
Mar 15, 2024
| run: | | ||
| python3 -m pip install --upgrade poetry | ||
| poetry -C express_relay/sdk/python/express_relay build | ||
| poetry build |
There was a problem hiding this comment.
Is it expected that you poetry build twice?
m30m
approved these changes
Mar 15, 2024
m30m
approved these changes
Mar 15, 2024
guibescos
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple fix to get publishing working