feat(contract_manager): more support for starknet contract #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ali-behjati
reviewed
Jun 20, 2024
| senderPrivateKey: PrivateKey, | ||
| vaas: Buffer[] | ||
| ): Promise<TxResult> { | ||
| throw new Error("Method not implemented."); | ||
| // We need the account address to send transactions. | ||
| throw new Error("Use executeUpdatePriceFeedWithAddress instead"); |
There was a problem hiding this comment.
Isn't there any way to fetch the address from private key? this (and the executeGovernance) will break some generic things that we can do. (like update price feed script)
There was a problem hiding this comment.
It's possible to derive it but it depends on the wallet application used to create the account and on the constructor arguments. Looks like the mainstream way of handling it is just to pass the account address explicitly.
There was a problem hiding this comment.
Since it's our own tooling, can't we just rely on that one?
if we had time, a better option would've been refactoring this code to have better interfaces.
ali-behjati
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.