fix(price-pusher): randomize price feed ids #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
changed the title
ali-behjati
approved these changes
Jul 10, 2024
| @@ -93,10 +93,11 @@ export class SolanaPricePusher implements IPricePusher { | |||
| return; | |||
| } | |||
|
|
|||
| const shuffledPriceIds = priceIds.sort(() => Math.random() - 0.5); | |||
There was a problem hiding this comment.
Hmmmm is this key computed only once? :? I'm wondering if it would crash if it's recalibrated each time
There was a problem hiding this comment.
I don't understand your comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solana devnet pusher doesn't work great.
Since we have no Jito, we need to land many transactions sequentially. And until now it sequentially follows the order in
price-config.yaml. In periods of bad landing rate it crashes before getting to the end of the sequence. Therefore price feeds towards the end of the list never get updated.By randomizing the order of price updates to avoid the imbalance between the top of the list and the bottom of the list in terms of frequency of updates.