Skip to content

chore(hermes): use stable rust toolchain in precommit formatter #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

tejasbadadare
Copy link
Contributor

@tejasbadadare tejasbadadare commented Nov 6, 2024

Fix a mismatch between the Hermes toolchain (stable) and the cargo fmt command run by precommit in CI (nightly). Reformat the sse.rs touched by #2102 to make it pass precommit.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:27pm
proposals ❌ Failed (Inspect) Nov 6, 2024 9:27pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 9:27pm
insights ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 9:27pm

@tejasbadadare tejasbadadare merged commit 02073a6 into main Nov 6, 2024
7 of 8 checks passed
@tejasbadadare tejasbadadare deleted the tb/hermes/fix-formatting branch November 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants