-
Notifications
You must be signed in to change notification settings - Fork 278
Implement the new IPyth events and methods #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, just one question here about the right way to accept payment in eth. see inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nicely done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a small question around feed update event structure
Very strangely after adding migration steps the old address used in evm relay became wormhole implementation address I looked at eth-0/tests container logs and saw the address is entirely different (before and after the change)
Changes:
updatePriceBatchFromVm
private.p.s: I tried to separate the changes but it was difficult as the new sdk version contained both changes.