Skip to content

Implement the new IPyth events and methods #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 28, 2022

Conversation

ali-behjati
Copy link
Collaborator

@ali-behjati ali-behjati commented Jul 25, 2022

Changes:

  • Emits multiple events that capture price updates.
  • Adds update fee, with setter and getter and the check. Also makes updatePriceBatchFromVm private.

p.s: I tried to separate the changes but it was difficult as the new sdk version contained both changes.

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just one question here about the right way to accept payment in eth. see inline

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nicely done

Copy link
Contributor

@drozdziak1 drozdziak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small question around feed update event structure

Very strangely after adding migration steps the old address
used in evm relay became wormhole implementation address
I looked at eth-0/tests container logs and saw the
address is entirely different (before and after the change)
@ali-behjati ali-behjati requested a review from jayantk July 28, 2022 12:53
@ali-behjati ali-behjati merged commit 5320c58 into main Jul 28, 2022
@ali-behjati ali-behjati deleted the abehjati/update-eth-contract branch July 28, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants