-
Notifications
You must be signed in to change notification settings - Fork 275
Quorum: Add ws and other metrics #2809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally a bit on the fence with the metrics
library because it's very flexible and if a metric is used in two places, there's chances of error (typo/...) but i can tolerate it.
Apart from these metrics, i like to see these two metrics too:
- number of active subscribers (so we can see if there's a decrease)
- number of observations sent per signer (so we can detect if a signer goes down)
I agree with your points. I chose to use the We can caculate the number of active subscribers by looking at the total number of ping updates sent by the server, which is why I didn’t add any other metric for active subscribers. I’ll add the "observations per signer" metric in the upcoming commits. |
No description provided.