Skip to content

Quorum: Add ws and other metrics #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

Quorum: Add ws and other metrics #2809

merged 3 commits into from
Jun 25, 2025

Conversation

danimhr
Copy link
Contributor

@danimhr danimhr commented Jun 25, 2025

No description provided.

Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:10pm

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally a bit on the fence with the metrics library because it's very flexible and if a metric is used in two places, there's chances of error (typo/...) but i can tolerate it.

Apart from these metrics, i like to see these two metrics too:

  • number of active subscribers (so we can see if there's a decrease)
  • number of observations sent per signer (so we can detect if a signer goes down)

@danimhr
Copy link
Contributor Author

danimhr commented Jun 25, 2025

I'm generally a bit on the fence with the metrics library because it's very flexible and if a metric is used in two places, there's chances of error (typo/...) but i can tolerate it.

Apart from these metrics, i like to see these two metrics too:

  • number of active subscribers (so we can see if there's a decrease)
  • number of observations sent per signer (so we can detect if a signer goes down)

I agree with your points. I chose to use the metrics crate because it's compatible with the Axum Prometheus. Also, the Quorum project is small, I think the current setup is fine for now.
We can define metric names as enum as well, if you think having it is necessary. Let me know if we have to add it before merge.

We can caculate the number of active subscribers by looking at the total number of ping updates sent by the server, which is why I didn’t add any other metric for active subscribers.

I’ll add the "observations per signer" metric in the upcoming commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants