Drozdziak1/p2w client use mapping crawl #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2022 13:35
This change adds code to append new symbols to an existing attestation config. In conjunction with the mapping crawling logic, this will aid in hot reloading attestation configs in runtime
ali-behjati
reviewed
Sep 21, 2022
| @@ -173,12 +173,13 @@ async fn main() -> Result<(), ErrBox> { | |||
| daemon, | |||
| } => { | |||
| // Load the attestation config yaml | |||
| let attestation_cfg: AttestationConfig = | |||
| let mut attestation_cfg: AttestationConfig = | |||
There was a problem hiding this comment.
maybe this one is not necessary here 🤔
There was a problem hiding this comment.
It's not possible to take a mutable reference to an immutable variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds and tests the merging of crawled mapping symbols with the existing attestation config. The additional symbols that were not previously seen in other symbol groups are added to a symbol group called "mapping", This mapping group can contain pre-existing symbols and, more importantly, attestation conditions, allowing to specify the default behavior for symbols found in the mapping