feat(lazer): add allowed feeds per publisher, aggregated prices and feature flags to state #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Riateche
changed the title
danimhr
approved these changes
Sep 4, 2025
|
@Riateche |
merolish
approved these changes
Sep 4, 2025
ali-behjati
reviewed
Sep 4, 2025
| // [required] If true, the publisher is active, i.e. it's allowed to publish updates. | ||
| optional bool is_active = 4; | ||
| // IDs of the feeds for which the publisher's price will be included in the aggregate. | ||
| repeated uint32 allowed_feed_ids = 5; |
There was a problem hiding this comment.
i was wondering which one makes more sense, allowed_feed_ids per publishers or allowed_pub_ids per price feeds?
There was a problem hiding this comment.
It's a symmetric many-to-many relationship, so it's fine in either case. In the memory representation we can also reverse it if needed. Having a property on publisher makes governance actions look more natural.
There was a problem hiding this comment.
Looks like line 140 anticipated it being added in Feed, outdated now:
// TODO: list of permissioned publisher IDs.
…blisher-sdk version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Implementing state and governance.
How has this been tested?