You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the current deduplication logic, dedup_by_key only removes the consecutive duplicated. It doesn't work if there an update for another feed in the middle of the 2 duplicated update for a feed.
We also improve the logic to only includes at most 1 update per feed. This is done by getting the last distinct update, while prioritizing the lower timestamps. This is because the aggregator effectively ignores the previous updates by immediately overriding them with new values.
How has this been tested?
Current tests cover my changes
Added new tests
Manually tested the code
Wrote a test that would fail with the current deduplication logic.
@keyvankhademi this wasn't a bug - we made a deliberate decision at the time not to censor any information sent to us by publishers and instead handle this in lazer after the updates are persisted to the db. But yes this will, at least with the publisher the dedup was originally added for, have a big reduction in the number of sent updates.
@keyvankhademi this wasn't a bug - we made a deliberate decision at the time not to censor any information sent to us by publishers and instead handle this in lazer after the updates are persisted to the db. But yes this will, at least with the publisher the dedup was originally added for, have a big reduction in the number of sent updates.
@bplatak No there was a real bug. See the example below:
feed_id, ts, price
1, 1, 10
2, 2, 20
1, 3, 10
The dedup_by_key will not remove the last entry because it only dedups consecutive elements.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the deduplication logic in agent.
Rationale
There is a bug in the current deduplication logic,
dedup_by_keyonly removes the consecutive duplicated. It doesn't work if there an update for another feed in the middle of the 2 duplicated update for a feed.We also improve the logic to only includes at most 1 update per feed. This is done by getting the last distinct update, while prioritizing the lower timestamps. This is because the aggregator effectively ignores the previous updates by immediately overriding them with new values.
How has this been tested?
Wrote a test that would fail with the current deduplication logic.